Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Ian Eiloart
Sympl
Commits
a38058e2
Commit
a38058e2
authored
Apr 06, 2016
by
Steve Kemp
Browse files
Document why directory-traversal attacks will fail.
I tested this too.
parent
b7c3ef06
Changes
1
Hide whitespace changes
Inline
Side-by-side
httpd-logger/symbiosis-httpd-logger.go
View file @
a38058e2
...
...
@@ -5,6 +5,28 @@
// The command-line flags are 100% compatible with the old implementation
// even though they are largely ignored.
//
//
// Security Concerns
// -----------------
//
// This might be running as root. Input such as this will create
// /etc/public/logs/accsss.log:
//
// ../etc foo bar baz
//
// In the real world this isn't a concern, a request to Apache wouldn't
// get as far as our logger:
//
// curl -H "Host: ../etc" http://example.vm.bytemark.co.uk/
// -> HTTP 400
// -> Bad Request
//
// Since the user can't start this as root, unless already root, or
// inject intput into the Apache-owned pipe this is not a concern.
//
// Suggested solution? Filter ".." from host-names. At the moment
// that isn't done, by the rationale above.
//
// Steve
// --
//
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment