disable-filesystem-security: Can’t disable with config/disable-filesystem-security

Summary

According to multiple pages in the wiki, you can use /srv/example.com/config/disable-filesystem-security to disable on a per-site basis. However only ${domain}/config/do-not-secure for per-site or /etc/sympl/disable-filesystem-security for server-wide works.

https://wiki.sympl.io/view/Website_Configuration_Reference#Filesystem_Permissions

https://wiki.sympl.io/view/Configuration_Reference

See line 170 in the sympl-filesystem-security script

https://gitlab.mythic-beasts.com/sympl/sympl/-/blob/bullseye/core/sbin/sympl-filesystem-security#L170

Steps to reproduce

• Create /srv/example.com/config/disable-filesystem-security
• change ownership of any file in the public directory
• run sudo sympl-filesystem-security
• the ownership is changed back, despite the script supposedly being disabled for this domain

Example Project

See the script’s code, it doesn’t check on the file described in the wiki. It only checks the global config file, not the domain specific one.

https://gitlab.mythic-beasts.com/sympl/sympl/-/blob/bullseye/core/sbin/sympl-filesystem-security#L170

What is the current bug behavior?

Doesn’t disable filesystem ownership changes in the domain

/srv/example.com/config/disable-filesystem-security

What is the expected correct behavior?

According to multiple pages in the wiki, you can use /srv/example.com/config/disable-filesystem-security to disable on a per-site basis. However only ${domain}/config/do-not-secure works.

https://wiki.sympl.io/view/Website_Configuration_Reference#Filesystem_Permissions

https://wiki.sympl.io/view/Configuration_Reference

Possible fixes

See line 170 in the sympl-filesystem-security script

https://gitlab.mythic-beasts.com/sympl/sympl/-/blob/bullseye/core/sbin/sympl-filesystem-security#L170

/cc @kelduum